Common: Optional Param Dict Name to avoid Parameter Re-Addition #3696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id re-addition of parameters (performance)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: e738cab | Previous: 9856f66 | Ratio |
|---|---|---|---|
Block 9422905 |
7375 ops/sec (±1.76%) |
37877 ops/sec (±1.73%) |
5.14 |
Block 9422906 |
7203 ops/sec (±1.17%) |
35937 ops/sec (±3.35%) |
4.99 |
Block 9422907 |
6974 ops/sec (±3.99%) |
36656 ops/sec (±1.46%) |
5.26 |
Block 9422908 |
6951 ops/sec (±3.63%) |
35733 ops/sec (±1.60%) |
5.14 |
Block 9422910 |
6616 ops/sec (±4.29%) |
34971 ops/sec (±1.78%) |
5.29 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When experimenting along #3694 I realized that (re-)adding the Common parameters with
updateParams()comes with a somewhat significant performance cost and often - e.g. for a shared Common in Client - the addition is not necessary since the parameter set is already there.This PR adds the ability to give the parameter set a name which is then checked for along further additions to void re-adding unnecessarily.
The PR also removes the
resetParam()method. This was a hypothetical method I added, because I thought it might be useful for someone. Seems overblown to me now (respectively we can always re-add), we ourselves use this method nowhere in the monorepo.